Merged
Conversation
…r deathlinks, and don't reset the timer if we don't actually update
minous27
requested changes
Feb 4, 2023
Owner
minous27
left a comment
There was a problem hiding this comment.
Questions about the merged rando code
minous27
approved these changes
Feb 6, 2023
Owner
|
This looks great! I wouldn't mind testing this with ya sometime to see how setup goes and do a runthrough. |
Contributor
Author
|
docs and ap implementation is all here https://github.com/alwaysintreble/Archipelago/tree/messenger/worlds/messenger. to run it you can just download the linked folder, zip it, rename the extension to |
# Conflicts: # RandomizerMain.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting this in draft status as it isn't quite finished. Currently this will allow the user to connect to an AP server and then the randomizer mappings are pulled and saved from the slot data of the connected server. Items for other players have the dialog text overwritten to display what the item is and who it's for. Player is also able to Close the game and reconnect to the server with the same save by simply loading the file (no text entry required!), but the logic around this is currently buggy, likely due to me passing around save data too frequently, plus the fact that connecting to the server is a thread task possibly muddying up the order of operations though this shouldn't matter. Logic/no logic and basic/advanced seeds are done server side here. No logic has logic on all of the locations, but the accessibility is set to minimal and the goal is considered always reachable, so items can be self-locking and nothing is guaranteed. Other players' items will still be accessible in this mode to facilitate multiworld play.
Issues:
-. Current solution is to replacein the provided url with.and inform the player about the limitation.The connection itself is stable. Checks will still happen and get queued up if the player disconnects at any point, and it will attempt to reconnect to the server every 5 seconds. Loop to check if items should be unlocked is currently executed every second, and received time shards currently always grant a quantity of 69.
Honestly didn't expect I would make this much progress this quickly, even if it does need some work still.