fix(glue): return null LocationUri when database has none#514
Merged
Nahuel990 merged 2 commits intoministackorg:mainfrom Apr 29, 2026
Merged
fix(glue): return null LocationUri when database has none#514Nahuel990 merged 2 commits intoministackorg:mainfrom
Nahuel990 merged 2 commits intoministackorg:mainfrom
Conversation
|
Docker image for this PR has been published: |
Contributor
Author
|
Confirmed this fixes the issue. The preview builds are excellent 👌 |
|
Docker image for this PR has been published: |
Nahuel990
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glue's
CreateDatabasewas defaultingLocationUrito""when not provided. AWS and Localstack both returnnullin this case, and Iceberg relies on this — it checksdatabase.getLocationUri() == nullto detect a missing location (GlueCatalog.java:299).Fixes the default to
Noneso it serialises as JSONnull, and adds a test covering both the absent and present cases.