Repository navigation
fix(lambda): start Node.js and Python functions in the code directory - #1968
Merged
Merged
Conversation
The warm worker and the one-shot invoke path spawned the runtime without a cwd, so process.cwd() was MiniStack's own directory. AWS starts the function in LAMBDA_TASK_ROOT.
|
Docker image for this PR has been published: Plugin donor used by the regular variant: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1965.
The warm Lambda worker (and the one-shot invoke path) spawned node/python without a
cwd, soprocess.cwd()was MiniStack's own directory rather than the extracted code, unlike AWS where it isLAMBDA_TASK_ROOT. Libraries such as node-config that read files relative to the cwd missed the function's config. Both spawns now passcwd=code_dir.New tests
test_node_worker_cwd_is_code_dirandtest_python_worker_cwd_is_code_dirfail without the change (cwd is the repo dir) and pass with it. The one-shot path is not covered by a test.tests/test_lambda_runtime_worker.pypasses (19 passed)ruff check ministack/passespytest tests/not run (needs a running server)CHANGELOG.md