This repository was archived by the owner on Jun 4, 2025. It is now read-only.
This repository was archived by the owner on Jun 4, 2025. It is now read-only.
Fix periodic update of status icon color for system tray #3173
Description
While working on #3058 (see: #3058 (comment)) we found out that the status icon was incorrectly updated this happened due to the command minishift status --profile <name> returning some iaddress:port instead of correct o/p.
Console log from the getStatus() function:
2019-02-20 13:10:32.157 minishift[1663:6381937] Done loading image
2019-02-20 13:10:32.157 minishift[1663:6381937] Done setting image
Minishift: Stopped
Profile: minishift
OpenShift: Stopped
DiskUsage: Unknown
CacheUsage: 1.828 GB (used by oc binary, ISO or cached images)
2019-02-20 13:10:37.547 minishift[1663:6381939] Done loading image
2019-02-20 13:10:37.547 minishift[1663:6381939] Done setting image
Minishift: Stopped
Profile: minishift
OpenShift: Stopped
DiskUsage: Unknown
CacheUsage: 1.828 GB (used by oc binary, ISO or cached images)
2019-02-20 13:10:42.937 minishift[1663:6381939] Done loading image
2019-02-20 13:10:42.937 minishift[1663:6381939] Done setting image
127.0.0.1:64791 <=== instead of minishift status o/p
2019-02-20 13:10:57.982 minishift[1663:6381939] Done loading image
2019-02-20 13:10:57.982 minishift[1663:6381939] Done setting image
127.0.0.1:64794 <=== instead of minishift status o/p
2019-02-20 13:11:13.025 minishift[1663:6381937] Done loading image
2019-02-20 13:11:13.025 minishift[1663:6381937] Done setting image
2019-02-20 13:11:13.025 minishift[1663:6381937] Done loading image
2019-02-20 13:11:13.025 minishift[1663:6381937] Done setting image
127.0.0.1:64810 <=== instead of minishift status o/pNOTE: I have tried to reproduce this by running the same command minishift status --profile <name> repeatedly from a terminal and it works fine.
Since, it is showing incorrect status, till we find the cause for it, I suggest we remove the following piece of code that periodically updates the icons. After which the icons will only change color once a start/stop action is performed from the tray menu.
Issue is fixed upon using what @LalatenduMohanty Mentioned in #3173 (comment)