You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request refactors the logic for uploading parts in the composeObject method to use sequential processing of uploads.
Changes
Changed the uploadAllParts function to upload parts in chunks using a for...of loop and await, instead of running all uploads in parallel with Promise.all.
This change limits simultaneous number of requests, which may help with rate-limiting.
Using multipart upload provides the following advantages:
Improved throughput – You can upload parts in parallel to improve throughput.
Quick recovery from any network issues – Smaller part size minimizes the impact of restarting a failed upload due to a network error.
Pause and resume object uploads – You can upload object parts over time. After you initiate a multipart upload, there is no expiry; you must explicitly complete or stop the multipart upload.
Begin an upload before you know the final object size – You can upload an object as you create it.
@prakashsvmx I've just tried to run this 1k parts compose test against play.min.io using this little test inway/minio-compose-object with BUCKET_NAME set to minio-compose-object (I've already populated this bucket with parts) so feel free to test it on your own.
After setting minioClient.traceOn(); on Minio client you can see that it hits 429 status pretty fast...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the logic for uploading parts in the
composeObjectmethod to use sequential processing of uploads.Changes
uploadAllPartsfunction to upload parts in chunks using afor...ofloop andawait, instead of running all uploads in parallel withPromise.all.composeObjectcan lead to DoS #1441