Fix: redirect xml parser error to stream error, else error is uncatchable #1416
Merged
prakashsvmx merged 2 commits intominio:masterfrom Sep 4, 2025
Merged
Fix: redirect xml parser error to stream error, else error is uncatchable #1416prakashsvmx merged 2 commits intominio:masterfrom
prakashsvmx merged 2 commits intominio:masterfrom
Conversation
currently parser error like: https://github.com/minio/minio-js/blob/8.0.5/src/xml-parsers.js#L101 will be un-catchable from app code
Member
|
@dr-js , could you please re base ? |
prakashsvmx
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently parser error like:
https://github.com/minio/minio-js/blob/8.0.5/src/xml-parsers.js#L101 will be un-catchable from app code
to reproduce similar situation, change local code in
parseListObjectsV2innode_modules/minio/dist/main/xml-parsers.jsto:and try catch this error from
mc.listObjectsV2()