Skip to content

Support if-none-match and if-match headers.#1366

Merged
harshavardhana merged 1 commit intominio:masterfrom
cmrigney:support-if-match-headers
Dec 18, 2024
Merged

Support if-none-match and if-match headers.#1366
harshavardhana merged 1 commit intominio:masterfrom
cmrigney:support-if-match-headers

Conversation

@cmrigney
Copy link
Copy Markdown
Contributor

@cmrigney cmrigney commented Dec 12, 2024 •
edited
Loading

S3 and the Minio server both support conditional writes using If-None-Match and If-Match. Fwiw, this is already supported in the Go client.

Previously this was treating those parameters as metadata, but now they're treated as proper headers.

Example:

minioClient.putObject(
  "my-bucket",
  "my-object",
  "object-content",
  undefined,
  {
    "If-None-Match": "*",
  }
);

@prakashsvmx
Copy link
Copy Markdown
Member

prakashsvmx commented Dec 13, 2024

Thank you for the contribution @cmrigney . Could you please add a functional test ?

@harshavardhana
Copy link
Copy Markdown
Member

harshavardhana commented Dec 18, 2024

Thank you for the contribution @cmrigney . Could you please add a functional test ?

@prakashsvmx lets take this and add functional tests ourselves.

@harshavardhana harshavardhana merged commit f4812b2 into minio:master Dec 18, 2024
@cmrigney cmrigney deleted the support-if-match-headers branch December 18, 2024 17:07
@cmrigney
Copy link
Copy Markdown
Contributor Author

cmrigney commented Dec 18, 2024

Thanks! Sorry, I hadn't got around to it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmrigney @prakashsvmx @harshavardhana