Skip to content

fix: add missing file extension to import#1336

Merged
kaankabalak merged 1 commit intominio:masterfrom
Azlond:master
Aug 27, 2024
Merged

fix: add missing file extension to import#1336
kaankabalak merged 1 commit intominio:masterfrom
Azlond:master

Conversation

@Azlond
Copy link
Copy Markdown
Contributor

@Azlond Azlond commented Aug 22, 2024

The type import of PostPolicyResult in src/internal/client.ts is missing its file extension.

This can cause issues with projects requiring file extensions on import paths:

node_modules/minio/dist/esm/internal/client.d.mts:11:39 - error TS2307: Cannot find module '../minio' or its corresponding type declarations.

11 import type { PostPolicyResult } from '../minio';
                                         ~~~~~~~~~~


Found 1 error in node_modules/minio/dist/esm/internal/client.d.mts:11

I've added a .ts file extension similar to the import of xml-parser.ts, which also only exists as .js-file

@kaankabalak kaankabalak merged commit fe4d95f into minio:master Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@kaankabalak kaankabalak kaankabalak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Azlond @prakashsvmx @kaankabalak