Fix type definition entry point#1315
Merged
harshavardhana merged 1 commit intominio:masterfrom Jul 21, 2025
Merged
Conversation
Contributor
Author
|
Does anyone pay attention to this PR? This may be a very minor problem, please confirm whether it needs to be dealt with |
prakashsvmx
requested changes
Jul 23, 2024
Member
prakashsvmx
left a comment
There was a problem hiding this comment.
This conflicts with
fix: minio type definition not exported in package.json. close #1257.
So please double check and provide a reproducer to validate it.
Contributor
Author
Contributor
Author
|
But the directory |
prakashsvmx
approved these changes
Apr 30, 2025
|
And its not possible to annotate the return type explicitly, because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Hello, I'm currently using version 8.0.1, but I still encountered this issue Cannot find type definition file for 'minio' yesterday.
The current entry point
"types": "./types/esm/minio.d.ts"is incorrect, and the actual directory 'types' does not exist, as shown in the screenshot below.The correct address should be
"types": "./dist/main/minio.d.ts"