Ensure default expiration parameter is set for presigned URLs#1313
Merged
prakashsvmx merged 5 commits intominio:masterfrom Jul 2, 2024
Merged
Ensure default expiration parameter is set for presigned URLs#1313prakashsvmx merged 5 commits intominio:masterfrom
prakashsvmx merged 5 commits intominio:masterfrom
Conversation
This is handled by the callbackify wrapper Signed-off-by: Brendan Dalpe <[email protected]>
Signed-off-by: Brendan Dalpe <[email protected]>
Signed-off-by: Brendan Dalpe <[email protected]>
Signed-off-by: Brendan Dalpe <[email protected]>
Member
|
@bdalpe , Thank you, could you please resolve the lint/format issues ? |
Signed-off-by: Brendan Dalpe <[email protected]>
Contributor
Author
|
@prakashsvmx update pushed to fix the formatting issue in the test |
prakashsvmx
approved these changes
Jun 27, 2024
kaankabalak
approved these changes
Jul 2, 2024
Contributor
|
This is quite a significant breakage. Could we please get a bugfix release ASAP? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1312
Additionally, remove unnecessary
isFunctionchecks as that is now handled by the callbackify wrapper.Added module in unit test library for better coverage.