Skip to content

refactor bucket lifecycle apis to ts#1276

Merged
prakashsvmx merged 2 commits intominio:masterfrom
prakashsvmx:ref-ts-lifecycle
Apr 11, 2024
Merged

refactor bucket lifecycle apis to ts#1276
prakashsvmx merged 2 commits intominio:masterfrom
prakashsvmx:ref-ts-lifecycle

Conversation

@prakashsvmx
Copy link
Copy Markdown
Member

refactor
setBucketLifecycle
getBucketLifecycle
removeBucketLifecycle

apis to typescript.

@prakashsvmx prakashsvmx self-assigned this Apr 5, 2024
@prakashsvmx prakashsvmx marked this pull request as draft April 5, 2024 08:06
@prakashsvmx prakashsvmx marked this pull request as ready for review April 5, 2024 09:33
@prakashsvmx prakashsvmx requested a review from kaankabalak April 5, 2024 09:33
Copy link
Copy Markdown
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a very small note: Seems like the commit title exceeds the 72 character limit, would it be possible to edit that before merging?

@prakashsvmx prakashsvmx changed the title refactorsetBucketLifecycle getBucketLifecycle removeBucketLifecycle to ts refactor bucket lifecycle apis to ts Apr 11, 2024
@prakashsvmx prakashsvmx merged commit b5a8d3f into minio:master Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants