Update the JavaScript SDK Quickstart#1236
Conversation
|
We focus on supporting node LTS versions. https://nodejs.org/en/about/previous-releases @feorlen . |
|
in fact it support down to node v12 |
|
Finally able to get back to this, it's become a lower priority task for other reasons. But I still need to know something about JS for future work, so worth getting right. Appreciate any additional comments. |
|
Updated the Are there still needed changes in the examples dir? |
|
@feorlen formatter check is failing, you should do |
aldy505
left a comment
aldy505
left a comment
There was a problem hiding this comment.
The changes looks good to me.
Pinging @trim21 @prakashsvmx @kaankabalak for review.
|
Looks like I installed Appreciate the guidance getting through this! |
5 participants
Some small updates so the text better matches Docs style, since this README is imported directly into the web docs.
I made a few changes to the example also, like make it work if the bucket exists. I'm not a great JavaScript person so please let me know the usual style so it makes sense.
I was able to run the example with the latest Node.js, seems like it requires at least v 16. Is that accurate? When I tried with v12.22.9 I got
required: { node: '^16 || ^18 || >=20' }.Corresponding Docs issue minio/docs#1042