refactor: remove ObjectUplaoder and turn stream uploading#1227
Merged
prakashsvmx merged 27 commits intominio:masterfrom Nov 28, 2023
Merged
refactor: remove ObjectUplaoder and turn stream uploading#1227prakashsvmx merged 27 commits intominio:masterfrom
ObjectUplaoder and turn stream uploading#1227prakashsvmx merged 27 commits intominio:masterfrom
Conversation
trim21
changed the title
ObjectUplaoder and turn stream uploading
Contributor
Author
aldy505
reviewed
Nov 24, 2023
Contributor
aldy505
left a comment
aldy505
left a comment
There was a problem hiding this comment.
LGTM overall, but here are some nitpicks.
getContentLength function
prakashsvmx
approved these changes
Nov 27, 2023
Member
prakashsvmx
left a comment
prakashsvmx
left a comment
There was a problem hiding this comment.
Tested. Changes look good to me. 👍
Contributor
Author
kaankabalak
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #1045
previously, if user want to upload a stream, for example:
s3.putObject('...', '...', fs.createReadStream('...')), minio-js will usemaxObjectSizeas object size and 500 mb as chunk size.after this patch, when
putObjectis used with a stream created byfs.createReadStream, minio-js will try to read file size as object size, and use proper chunk size.