Skip to content

refactor: setBucketPolicy#1221

Merged
prakashsvmx merged 17 commits intominio:masterfrom
trim21:setBucketPolicy
Nov 29, 2023
Merged

refactor: setBucketPolicy#1221
prakashsvmx merged 17 commits intominio:masterfrom
trim21:setBucketPolicy

Conversation

@trim21
Copy link
Copy Markdown
Contributor

@trim21 trim21 commented Oct 31, 2023

No description provided.

@trim21 trim21 marked this pull request as draft November 3, 2023 19:47
@trim21 trim21 closed this Nov 4, 2023
@trim21 trim21 reopened this Nov 14, 2023
@trim21 trim21 marked this pull request as ready for review November 22, 2023 11:07
Copy link
Copy Markdown
Contributor

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx
Copy link
Copy Markdown
Member

Please resolve the conflicts. @trim21

@trim21 trim21 requested a review from prakashsvmx November 28, 2023 10:00
@trim21
Copy link
Copy Markdown
Contributor Author

trim21 commented Nov 28, 2023

@kaankabalak

@kaankabalak kaankabalak self-requested a review November 28, 2023 17:41
Copy link
Copy Markdown
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx prakashsvmx merged commit cbf83dd into minio:master Nov 29, 2023
trim21 added a commit to trim21/minio-js that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants