fix batch deletion in removeObjects#1131
Merged
harshavardhana merged 1 commit intominio:masterfrom Apr 26, 2023
Merged
Conversation
Contributor
|
@prakashsvmx Is there any specific reason for the changes in the package.json file? As far as I can see, we aren't using any new packages for the code changed in |
Member
Author
|
It just lock file version upgrade as per npm. |
harshavardhana
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix:
removeObjectsdoes not delete more than 1000 objects.test data setup. generate n number of objects for testing batched deletion from js sdk.
now try to delete from the sdk