Add post-call checks on AppendObject#2178
Merged
harshavardhana merged 1 commit intominio:masterfrom Nov 12, 2025
Merged
Conversation
Using Append (via PutObject as designed) on a server that doesn't support it can just overwrite the object.. Kinda crappy design by AWS. There is no "preflight" info in HeadObject to indicate if the object is appendable. Add post-call checks on the expected size to at least indicate to the client there is an issue.
vadmeste
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Append (via PutObject as designed) on a server that doesn't support it can just overwrite the object.. Kinda crappy design by AWS. There is no "preflight" info in HeadObject to indicate if the object is appendable.
Add post-call checks on the expected size to at least indicate to the client there is an issue.