Only marshal lifecycle rule Filter XML when not empty#2177
Merged
harshavardhana merged 1 commit intominio:masterfrom Nov 8, 2025
amigan:checkEmptyFilter
Merged
Only marshal lifecycle rule Filter XML when not empty#2177harshavardhana merged 1 commit intominio:masterfrom amigan:checkEmptyFilter
harshavardhana merged 1 commit intominio:masterfrom
amigan:checkEmptyFilter
Conversation
klauspost
approved these changes
Nov 8, 2025
harshavardhana
approved these changes
Nov 8, 2025
amigan
added a commit
to amigan/stillbox
that referenced
this pull request
Nov 9, 2025
minio/minio-go#2177 was merged.
isimluk
added a commit
to isimluk/minio-go
that referenced
this pull request
Mar 18, 2026
https://docs.aws.amazon.com/AmazonS3/latest/API/API_LifecycleRule.html mentions that Filter is required if the LifecycleRule does not contain a Prefix element. After minio#2177, this requirement is broken for bucket-global (=prefixless) rules. And clients setting such may run into server side validation issues like. HTTP/1.1 400 Bad Request <?xml version="1.0" encoding="UTF-8"?> <Error> <Code>MalformedXML</Code> ... </Error>
isimluk
added a commit
to isimluk/minio-go
that referenced
this pull request
Mar 19, 2026
https://docs.aws.amazon.com/AmazonS3/latest/API/API_LifecycleRule.html mentions that Filter is required if the LifecycleRule does not contain a Prefix element. After minio#2177, this requirement is broken for bucket-global (=prefixless) rules. And clients setting such may run into server side validation issues like. HTTP/1.1 400 Bad Request <?xml version="1.0" encoding="UTF-8"?> <Error> <Code>MalformedXML</Code> ... </Error>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of sorts of minio/minio#10851. Some server implementations (namely, DigitalOcean Spaces) a) do not work with the modern
Rule.Filter.Prefixstructure, and b) actively ignore anyRule.Prefixwhen anyFilterwhatsoever appears in the XML.