Merged
Conversation
Contributor
Author
|
For some added context: when using this client in a high volume service I noticed the number of goroutines was roughly double what I expected. This was because for every routine executing an operation, another routine had spun up handling the retries. Adding this change would eliminate the need for a separate goroutine for the retry delays and improve performance |
tlyons-cs
force-pushed
the
rety_iterators
branch
from
804cb63 to
49299c2
Compare
klauspost
approved these changes
Apr 4, 2025
Contributor
klauspost
left a comment
klauspost
left a comment
There was a problem hiding this comment.
Looks like a solid refactor!
Member
|
@tlyons-cs can you fix the linter errors? |
tlyons-cs
force-pushed
the
rety_iterators
branch
from
49299c2 to
ed417eb
Compare
harshavardhana
approved these changes
Apr 4, 2025
project-mirrors-bot-tu bot
pushed a commit
to project-mirrors/forgejo
that referenced
this pull request
Apr 9, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/minio/minio-go/v7](https://github.com/minio/minio-go) | require | patch | `v7.0.88` -> `v7.0.90` | --- ### Release Notes <details> <summary>minio/minio-go (github.com/minio/minio-go/v7)</summary> ### [`v7.0.90`](https://github.com/minio/minio-go/releases/tag/v7.0.90): Bugfix v7.0.90 [Compare Source](minio/minio-go@v7.0.89...v7.0.90) #### What's Changed - Add anonymous chunked encoding with trailing headers by [@​klauspost](https://github.com/klauspost) in minio/minio-go#2084 - Implement AppendObject() API by [@​harshavardhana](https://github.com/harshavardhana) in minio/minio-go#2082 - Update x/net version by [@​BorjaOuterelo](https://github.com/BorjaOuterelo) in minio/minio-go#2085 - Rety iterators by [@​tlyons-cs](https://github.com/tlyons-cs) in minio/minio-go#2087 - Add function for getting creds of remote client by [@​shtripat](https://github.com/shtripat) in minio/minio-go#2089 #### New Contributors - [@​BorjaOuterelo](https://github.com/BorjaOuterelo) made their first contribution in minio/minio-go#2085 - [@​tlyons-cs](https://github.com/tlyons-cs) made their first contribution in minio/minio-go#2087 **Full Changelog**: minio/minio-go@v7.0.89...v7.0.90 ### [`v7.0.89`](https://github.com/minio/minio-go/releases/tag/v7.0.89): Bugfix Release [Compare Source](minio/minio-go@v7.0.88...v7.0.89) #### What's Changed - add PurgeOnDelete to versioning config by [@​poornas](https://github.com/poornas) in minio/minio-go#2074 - Adds `TokenRevokeType` field to credential providers. by [@​taran-p](https://github.com/taran-p) in minio/minio-go#2075 - make downtime info as map to denote per target info by [@​Praveenrajmani](https://github.com/Praveenrajmani) in minio/minio-go#2079 - update deps and move CI/CD to go1.23, go1.24 by [@​harshavardhana](https://github.com/harshavardhana) in minio/minio-go#2080 - update golint version by [@​harshavardhana](https://github.com/harshavardhana) in minio/minio-go#2083 #### New Contributors - [@​taran-p](https://github.com/taran-p) made their first contribution in minio/minio-go#2075 **Full Changelog**: minio/minio-go@v7.0.88...v7.0.89 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMzMuNSIsInVwZGF0ZWRJblZlciI6IjM5LjIzMy41IiwidGFyZ2V0QnJhbmNoIjoiZm9yZ2VqbyIsImxhYmVscyI6WyJkZXBlbmRlbmN5LXVwZ3JhZGUiLCJ0ZXN0L25vdC1uZWVkZWQiXX0=--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7495 Reviewed-by: Earl Warren <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the transition to go 1.23 the internal retry goroutine+channel can be replaced with an iter.Seq[int]. This reduces the memory allocation of a new goroutine and the extra overhead for waiting on the receipt/done channels.