fix(googlereader): fix incorrect read/starred toggling#4277
Merged
Conversation
Add a !read / !starred guard to the else-if branch so that the handler only toggles the state when the requested value differs from the current one.
dsh2dsh
added a commit
to dsh2dsh/miniflux
that referenced
this pull request
May 3, 2026
dsh2dsh
added a commit
to dsh2dsh/miniflux
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you followed these guidelines?
Problem
When using the Google Reader API to mark an entry as read or starred, if the entry was already in the target state, the handler would incorrectly toggle it to the opposite state instead of leaving it unchanged.
For example, calling the API to mark an already-read entry as read would result in it being marked as unread.
The root cause is a missing
!read(and!starred) guard in theelse ifbranch:Without the
!readcheck, the condition only tests the current state of the entry, not whether the requested state differs from it, causing idempotent API calls to have unintended side effects.Changes
readstate toggling: add!readguard to theelse ifbranchin the stream tag handler so that already-read entries are not
re-queued as unread.
starredstate handler for consistency.Example
When clicking "Mark all as read" in Read You to mark at least one articles as read, Read You tries to mark every article as read, including read articles.
Experiment steps:
Before Change
Unread articles are marked as read, but read articles become unread again.
before.mp4
After Change
All articles become read.
after.mp4