Repository navigation
[models] Raise a clear error for an empty crop in RecognitionPredictor - #2221
Merged
felixdittrich92 merged 1 commit intoNov 11, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2221 +/- ##
==========================================
- Coverage 97.86% 97.83% -0.04%
==========================================
Files 171 171
Lines 11774 11777 +3
==========================================
- Hits 11523 11522 -1
- Misses 251 255 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
felixdittrich92
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling a recognition predictor directly with an empty crop (a zero height, width or channel count, e.g. a box that was cropped to nothing) failed deep inside the preprocessing with
ZeroDivisionErrorwhile splitting or resizing the crop, without saying which input was wrong.RecognitionPredictornow raisesValueError: incorrect input shape: crops are expected to be non-empty, got shape (0, 20, 3)., next to the existing check on the number of dimensions.ocr_predictoralready drops empty crops before recognition, so it is unaffected. Test added (fails on main)