Skip to content

[transforms] Rotate an image without any box in rotate_sample - #2216

Merged
felixdittrich92 merged 1 commit into
mindee:mainfrom
RavSinghChandan:rotate-sample-no-geoms
Nov 3, 2026
Merged

felixdittrich92 merged 1 commit into
mindee:mainfrom
RavSinghChandan:rotate-sample-no-geoms

Conversation

@RavSinghChandan

Copy link
Copy Markdown
Contributor

rotate_sample(img, np.zeros((0, 4)), angle) raised ValueError: zero-size array to reduction operation maximum which has no identity from the np.max(geoms) <= 1 check used to detect relative coordinates. An image without any box (e.g. no text) is now rotated, with an empty (0, 4, 2) array of polygons, like crop_detection already handles an empty array of boxes.

Test added to test_rotate_sample for empty boxes and polygons (fails on main).

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.78%. Comparing base (a800f48) to head (92ca99f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2216      +/-   ##
==========================================
- Coverage   97.79%   97.78%   -0.01%     
==========================================
  Files         170      170              
  Lines       10997    10998       +1     
==========================================
  Hits        10754    10754              
- Misses        243      244       +1     
Flag Coverage Δ
unittests 97.78% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felixdittrich92 felixdittrich92 self-assigned this Nov 3, 2026

@felixdittrich92 felixdittrich92 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@felixdittrich92 felixdittrich92 added this to the 1.2.0 milestone Nov 3, 2026
@felixdittrich92 felixdittrich92 added type: enhancement Improvement ext: tests Related to tests folder module: transforms Related to doctr.transforms labels Nov 3, 2026
@felixdittrich92
felixdittrich92 merged commit 24ce391 into mindee:main Nov 3, 2026
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ext: tests Related to tests folder module: transforms Related to doctr.transforms type: enhancement Improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants