Repository navigation
[models] Invert an empty list or dict in invert_data_structure - #2211
Merged
felixdittrich92 merged 1 commit intoOct 31, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2211 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 170 170
Lines 10986 10986
=======================================
Hits 10743 10743
Misses 243 243
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
felixdittrich92
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invert_data_structure([]) raised IndexError (it reads the keys from x[0]), and invert_data_structure({}) raised
"All the lists in the dictionary should have the same length." although there are no lists at all. An empty
list now gives an empty dict and an empty dict an empty list. Lists of different lengths still raise.
Tests added to test_convert_list_dict; they fail on main.