Repository navigation
[models] Estimate the orientation of a float image (values in [0, 1]) in estimate_orientation - #2206
Merged
felixdittrich92 merged 1 commit intoOct 30, 2026
Conversation
… in estimate_orientation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2206 +/- ##
==========================================
- Coverage 97.77% 97.73% -0.05%
==========================================
Files 170 170
Lines 10980 10982 +2
==========================================
- Hits 10736 10733 -3
- Misses 244 249 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
felixdittrich92
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
estimate_orientationthresholds a color image with Otsu's method, which only takes 8-bit or 16-bit images, so a float image (values in [0, 1], like the predictors take) raised:A float color image is now scaled to uint8 first, so it gives the same angle as the uint8 image. The predictors call it on their segmentation maps, which are not affected