Repository navigation
[datasets] Check the word length range of WordGenerator upfront - #2203
Merged
felixdittrich92 merged 1 commit intoOct 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2203 +/- ##
==========================================
- Coverage 97.77% 97.75% -0.02%
==========================================
Files 170 170
Lines 10980 10982 +2
==========================================
Hits 10736 10736
- Misses 244 246 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
felixdittrich92
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordGeneratordrew each word length withrandom.randint(min_chars, max_chars)without checking the range. Withmin_chars=0(e.g.--min-chars 0inreferences/recognition/train.py), about half the samples were empty words, and each of them raisedValueError: unable to synthesize an image from an empty text, so training failed at a random step. Withmin_chars > max_chars, every sample raisedValueError: empty range in randrange(4, 3).The range is now checked when the dataset is created, and
1 <= min_chars <= max_charsis required