Repository navigation
[utils] Keep boxes without any area in nms - #2194
Merged
Merged
Conversation
felixdittrich92
approved these changes
Oct 30, 2026
felixdittrich92
added
type: enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2194 +/- ##
==========================================
- Coverage 97.75% 97.74% -0.01%
==========================================
Files 170 170
Lines 10959 10962 +3
==========================================
+ Hits 10713 10715 +2
- Misses 246 247 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nmsdivided the intersection by the union without a guard. For two boxes without any area (collapsed to a point or a line), that is 0 / 0: NumPy warnedinvalid value encountered in divide, and sincenan <= threshis false, the second box was suppressed even when the two boxes are far apart. Three such boxes at different places gave[0].The overlap is now 0 when the union is empty, as
box_ioualready does, so those boxes are kept. Boxes with an area give the same result as before