Repository navigation
[datasets] Reject negative indices in decode_sequence - #2189
Merged
felixdittrich92 merged 1 commit intoOct 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2189 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 170 170
Lines 10959 10961 +2
=======================================
+ Hits 10713 10715 +2
Misses 246 246
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
felixdittrich92
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decode_sequencerejected an index at or above the mapping size, but a negative one was read from the end of the mapping. The default EOS ofencode_sequencesis-1, sodecode_sequence(encode_sequences(["ab"], "abc")[0], "abc")returned"abc": the EOS came back as the last char of the vocab, with no error. Lists were not checked at all, so[2, 10]raised a bareIndexError.Negative indices now raise the same
AssertionErroras the indices that are too large, for arrays and lists. The recognition post-processors pass non-negativeargmaxindices, so they are not affected (the post-processor tests pass)