Repository navigation
Optimised overlay render logic - #30
Merged
hellohejinyu merged 1 commit intoOct 24, 2024
Merged
Conversation
Member
|
Thanks!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
IntroStepBuilderrenders overlay on the left side even when there is more space on the right, because thegetOverlayPositionfunction inside_StepWidgetBuilderverifies if there is more space on the sides compared to top and bottom spaces but it doesn't exactly calculate which side has more space.Before:
Screen.Recording.2024-10-23.at.1.36.07.PM.mov
After:
Screen.Recording.2024-10-23.at.1.40.42.PM.mov
to reproduce the issue add padding to the right above centre widget here in the example
flutter_intro/example/lib/group_usage.dart
Lines 4 to 12 in c73af8c
Like this: