@@ -364,12 +364,10 @@ def _parse_row_request(
364364 field ["name" ]: field for field in fields_info if not field .get ("auto_id" , False )
365365 }
366366
367- meta_field = (
368- schema_types .FieldData (is_dynamic = True , type = DataType .JSON ) if enable_dynamic else None
369- )
370- if meta_field is not None :
371- field_info_map [meta_field .field_name ] = meta_field
372- fields_data [meta_field .field_name ] = meta_field
367+ if enable_dynamic :
368+ d_field = schema_types .FieldData (is_dynamic = True , type = DataType .JSON )
369+ fields_data [d_field .field_name ] = d_field
370+ field_info_map [d_field .field_name ] = d_field
373371
374372 try :
375373 for entity in entities :
@@ -390,7 +388,7 @@ def _parse_row_request(
390388
391389 if enable_dynamic :
392390 json_value = entity_helper .convert_to_json (json_dict )
393- meta_field .scalars .json_data .data .append (json_value )
391+ d_field .scalars .json_data .data .append (json_value )
394392
395393 except (TypeError , ValueError ) as e :
396394 raise DataNotMatchException (message = ExceptionsMessage .DataTypeInconsistent ) from e
@@ -400,7 +398,7 @@ def _parse_row_request(
400398 )
401399
402400 if enable_dynamic :
403- request .fields_data .append (meta_field )
401+ request .fields_data .append (d_field )
404402
405403 _ , _ , auto_id_loc = traverse_rows_info (fields_info , entities )
406404 if auto_id_loc is not None :
@@ -418,16 +416,18 @@ def row_insert_param(
418416 collection_name : str ,
419417 entities : List ,
420418 partition_name : str ,
421- fields_info : Any ,
419+ fields_info : Dict ,
422420 enable_dynamic : bool = False ,
423421 ):
424422 if not fields_info :
425423 raise ParamError (message = "Missing collection meta to validate entities" )
426424
427425 # insert_request.hash_keys won't be filled in client.
428- tag = partition_name if isinstance (partition_name , str ) else ""
426+ p_name = partition_name if isinstance (partition_name , str ) else ""
429427 request = milvus_types .InsertRequest (
430- collection_name = collection_name , partition_name = tag , num_rows = len (entities )
428+ collection_name = collection_name ,
429+ partition_name = p_name ,
430+ num_rows = len (entities ),
431431 )
432432
433433 return cls ._parse_row_request (request , fields_info , enable_dynamic , entities )
@@ -445,9 +445,11 @@ def row_upsert_param(
445445 raise ParamError (message = "Missing collection meta to validate entities" )
446446
447447 # upsert_request.hash_keys won't be filled in client.
448- tag = partition_name if isinstance (partition_name , str ) else ""
448+ p_name = partition_name if isinstance (partition_name , str ) else ""
449449 request = milvus_types .UpsertRequest (
450- collection_name = collection_name , partition_name = tag , num_rows = len (entities )
450+ collection_name = collection_name ,
451+ partition_name = p_name ,
452+ num_rows = len (entities ),
451453 )
452454
453455 return cls ._parse_row_request (request , fields_info , enable_dynamic , entities )
@@ -469,7 +471,7 @@ def _pre_batch_check(
469471 if not fields_info :
470472 raise ParamError (message = "Missing collection meta to validate entities" )
471473
472- location , primary_key_loc , auto_id_loc = traverse_info (fields_info , entities )
474+ location , primary_key_loc , auto_id_loc = traverse_info (fields_info )
473475
474476 # though impossible from sdk
475477 if primary_key_loc is None :
@@ -583,16 +585,20 @@ def _prepare_placeholder_str(cls, data: Any):
583585
584586 elif isinstance (data [0 ], np .ndarray ):
585587 dtype = data [0 ].dtype
586- pl_values = (array .tobytes () for array in data )
587588
588589 if dtype == "bfloat16" :
589590 pl_type = PlaceholderType .BFLOAT16_VECTOR
591+ pl_values = (array .tobytes () for array in data )
590592 elif dtype == "float16" :
591593 pl_type = PlaceholderType .FLOAT16_VECTOR
592- elif dtype == "float32" :
594+ pl_values = (array .tobytes () for array in data )
595+ elif dtype in ("float32" , "float64" ):
593596 pl_type = PlaceholderType .FloatVector
597+ pl_values = (blob .vector_float_to_bytes (entity ) for entity in data )
598+
594599 elif dtype == "byte" :
595600 pl_type = PlaceholderType .BinaryVector
601+ pl_values = data
596602
597603 else :
598604 err_msg = f"unsupported data type: { dtype } "
0 commit comments