Repository navigation
fix(ci): drop registry-url from OIDC stable publish - #1109
Merged
Merged
Conversation
The 0.7.3 failure was IDENTITY_TOKEN_READ_ERROR mid parallel publish, not missing registry-url. Adding registry-url writes an empty _authToken line that blocks Trusted Publishing OIDC (actions/setup-node#1551). Keep force_publish dispatch to finish partial releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registry-urladdition on the stable Publish job from fix(ci): restore npm OIDC auth for stable publish #1108.IDENTITY_TOKEN_READ_ERRORduring parallelchangeset publish(OIDC token fetch flake), not missingregistry-url. Prior releases used the same workflow withoutregistry-urland succeeded.registry-urlonsetup-nodeis actively harmful for Trusted Publishing: it writes an empty_authTokenline that prevents OIDC (actions/setup-node#1551).workflow_dispatch+force_publishso we can finish[email protected]/ any remaining packages.Test plan
gh workflow run publish.yml -f force_publish=truenpm view react-doctor version→0.7.3Note
Low Risk
CI-only change to npm auth configuration for the stable publish job; no application runtime impact.
Overview
Reverts
registry-urlon the stable Publish job’sactions/setup-nodestep so npm Trusted Publishing can use OIDC again.setup-nodewithregistry-urlinjects an empty//registry.npmjs.org/:_authToken=${NODE_AUTH_TOKEN}entry, which blocks OIDC (actions/setup-node#1551). The workflow now documents that stable publish is OIDC-only;publish-devstill setsregistry-urlfor classic token flows.Reviewed by Cursor Bugbot for commit 996dbad. Bugbot is set up for automated code reviews on this repo. Configure here.