Merged
Conversation
Since error is not that large, especially for uniqCombined64(): rows error uniqCombined64()/rows - 1e7 0.00219 (1.0021969) - 1e8 0.00096 (0.99903523) - 2e8 0.50200 (1.005022735) - 1e9 0.99944 (0.999435738) - 1e10 0.01399 (0.9998568925) - 1e11 0.09800 (1.00097891658) - 1e12 0.29800 (0.997024870685) - 1e13 0.62200 (1.0062169910992) - 1e14 0.06200 (1.00062143604171)
Add PARTITION ID to OPTIMIZE documentation
Remove hardcoded paths in unwind target
Added integration test for #7414 (validation of `max_data_part_size_bytes`).
Allowed to have some parts on destination disk or volume in MOVE PARTITION
Better ambiguous column detection
Revert "Remove hardcoded paths in unwind target"
zlib's implementation uses CRC-32-IEEE 802.3 polynomial (0xedb88320) but with starting value 0xffffffff, so introduce another crc32 implementation - CRC32IEEE that has starting value - 0 Also add CRC64 with ECMA polynomial. v2: s/crc*_data./crc*_data./ to avoid conflicts with other crc32.h in contrib v3: join with existing CRC32()
Dictionaries ddl loader
Fix handling of SQL_FLOAT
After crc32() had been replaced with crc32_z() the following error will happen with two different zlib: 2019-10-25 09:48:42 /usr/bin/ld.gold: error: contrib/zlib-ng/libz.a(crc32.c.o): multiple definition of 'get_crc_table' 2019-10-25 09:48:42 /usr/bin/ld.gold: contrib/mariadb-connector-c/libmariadb/libmariadbclient.a(crc32.c.o): previous definition here Fix this by using zlibstatic compiled for and by CH in mariadb-connector-c, and wrap into function reduce variable scopes.
Fix HAVING without GROUP BY
Add handling of SQL_TINYINT and SQL_BIGINT, fix SQL_FLOAT in ODBC Bridge
remove some obsolete notes about mutations
update trainslation of fixedstring and fix the given examples of nullable in zh doc
Add CRC32IEEE()/CRC64() support
Add user setting mark_cache_min_lifetime documentation
millb
pushed a commit
that referenced
this pull request
Dec 18, 2019
The failure goes like this: https://clickhouse-test-reports.s3.yandex.net/7946/1f69a7a015468099b7395ce3b96fb638b9830e0b/functional_stateless_tests_(memory)/stderr.log ``` ==199==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x2009fc34 in LZ4_count /build/obj-x86_64-linux-gnu/../contrib/lz4/lib/lz4.c:541:13 #1 0x2009fc34 in LZ4_compress_generic /build/obj-x86_64-linux-gnu/../contrib/lz4/lib/lz4.c:999 #2 0x2009fc34 in LZ4_compress_fast_extState /build/obj-x86_64-linux-gnu/../contrib/lz4/lib/lz4.c:1140 #3 0x200ac663 in LZ4_compress_fast /build/obj-x86_64-linux-gnu/../contrib/lz4/lib/lz4.c:1211:14 #4 0x200ac663 in LZ4_compress_default /build/obj-x86_64-linux-gnu/../contrib/lz4/lib/lz4.c:1222 #5 0x1b76d2e8 in DB::CompressionCodecLZ4::doCompressData(char const*, unsigned int, char*) const /build/obj-x86_64-linux-gnu/../dbms/src/Compression/CompressionCodecLZ4.cpp:45:12 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
...
Detailed description (optional):
...