Merged
Conversation
Fixed issue of using HTTP timeout as TCP timeout value.
The fix follows from the 'storage_configuration.xml' file of the 'test_multiple_disks' integration test. The correct behaviour was tested on the local ClickHouse server version 19.15.3 revision 54426.
Miscellaneous formats improvements
Only storage policies can be set upon table creation. While disks must be defined in order to configure a storage policy, this logically follows from the above paragraph and does not need to be explicitly repeated.
…ich confirms this.
Fix ubsan introduced by Field refactoring.
Fixed function getMultipleValuesFromConfig
…7379) * Typo fix. * Links fix. * Fixed links in docs. * More fixes. * Link fixes. * DOCAPI-8299: Link update in RU docs.
Since there no information about this, while this can be interesting, for example to tune max_concurrent_queries in some cases.
murmurhash32 ubsan fix.
Fix UB in StoragesInfoStream
* GitHub labeler configuration changes * Delete main.workflow * Create labeler.yml * Create workflows/labeler.yml
* Potato goes to ClickHouse * Added comments * Fix YAML * Fix YAML * Fix label
Add a message in case of queue_wait_max_ms wait takes place
...so switch to blacklist
Fix docs on the tiered storage and add its translation into english
millb
pushed a commit
that referenced
this pull request
Oct 29, 2019
add test returned datatype from quantile and median result for empty …
millb
pushed a commit
that referenced
this pull request
Dec 18, 2019
The failure goes like this: https://clickhouse-test-reports.s3.yandex.net/7946/1f69a7a015468099b7395ce3b96fb638b9830e0b/functional_stateless_tests_(memory)/stderr.log ``` ==199==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x2009fc34 in LZ4_count /build/obj-x86_64-linux-gnu/../contrib/lz4/lib/lz4.c:541:13 #1 0x2009fc34 in LZ4_compress_generic /build/obj-x86_64-linux-gnu/../contrib/lz4/lib/lz4.c:999 #2 0x2009fc34 in LZ4_compress_fast_extState /build/obj-x86_64-linux-gnu/../contrib/lz4/lib/lz4.c:1140 #3 0x200ac663 in LZ4_compress_fast /build/obj-x86_64-linux-gnu/../contrib/lz4/lib/lz4.c:1211:14 #4 0x200ac663 in LZ4_compress_default /build/obj-x86_64-linux-gnu/../contrib/lz4/lib/lz4.c:1222 #5 0x1b76d2e8 in DB::CompressionCodecLZ4::doCompressData(char const*, unsigned int, char*) const /build/obj-x86_64-linux-gnu/../dbms/src/Compression/CompressionCodecLZ4.cpp:45:12 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
...
Detailed description (optional):
...