Multiply uses a readonly context #2558

mikefarah · mikefarah · commit 2824d66a65b7 · 2026-01-31T16:47:58.000+11:00
diff --git a/pkg/yqlib/operator_multiply.go b/pkg/yqlib/operator_multiply.go
@@ -30,7 +30,7 @@ func multiplyAssignOperator(d *dataTreeNavigator, context Context, expressionNod
 
 func multiplyOperator(d *dataTreeNavigator, context Context, expressionNode *ExpressionNode) (Context, error) {
 	log.Debugf("MultiplyOperator")
-	return crossFunction(d, context, expressionNode, multiply(expressionNode.Operation.Preferences.(multiplyPreferences)), false)
+	return crossFunction(d, context.ReadOnlyClone(), expressionNode, multiply(expressionNode.Operation.Preferences.(multiplyPreferences)), false)
 }
 
 func getComments(lhs *CandidateNode, rhs *CandidateNode) (leadingContent string, headComment string, footComment string) {
diff --git a/pkg/yqlib/operator_multiply_test.go b/pkg/yqlib/operator_multiply_test.go
@@ -96,6 +96,15 @@ var mergeWithGlobB = `
 `
 
 var multiplyOperatorScenarios = []expressionScenario{
+	{
+		description: "multiple should be readonly",
+		skipDoc:     true,
+		document:    "",
+		expression:  ".x |= (root | (.a * .b))",
+		expected: []string{
+			"D0, P[], ()::x: null\n",
+		},
+	},
 	{
 		description: "glob keys are treated as literals when merging",
 		skipDoc:     true,

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ func multiplyAssignOperator(d *dataTreeNavigator, context Context, expressionNod`
`30`	`30`
`31`	`31`	`func multiplyOperator(d dataTreeNavigator, context Context, expressionNode ExpressionNode) (Context, error) {`
`32`	`32`	`log.Debugf("MultiplyOperator")`
`33`		`- return crossFunction(d, context, expressionNode, multiply(expressionNode.Operation.Preferences.(multiplyPreferences)), false)`
	`33`	`+ return crossFunction(d, context.ReadOnlyClone(), expressionNode, multiply(expressionNode.Operation.Preferences.(multiplyPreferences)), false)`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`func getComments(lhs CandidateNode, rhs CandidateNode) (leadingContent string, headComment string, footComment string) {`