Skip to content

Comments

lib/Makefile.am: Use -no-undefined (for mingw32)#5

Open
mkoeppe wants to merge 1 commit intomiguelmarco:masterfrom
passagemath:no-undefined-for-mingw
Open

lib/Makefile.am: Use -no-undefined (for mingw32)#5
mkoeppe wants to merge 1 commit intomiguelmarco:masterfrom
passagemath:no-undefined-for-mingw

Conversation

@mkoeppe
Copy link

@mkoeppe mkoeppe commented Jul 15, 2025

Building libbraiding on mingw32 (Windows) gives this error:

  [libbraiding-1.3.1]   [spkg-install] /usr/bin/bash ../libtool  --tag=CXX   --mode=link g++ -std=gnu++11  -g -O2 -lm  -o libbraiding.la -rpath /d/a/passagemath/passagemath/sage-local/lib cbraid.lo braiding.lo  
  [libbraiding-1.3.1]   [spkg-install] libtool:   error: can't build x86_64-w64-mingw32 shared library unless -no-undefined is specified
  [libbraiding-1.3.1]   [spkg-install] make[6]: *** [Makefile:425: libbraiding.la] Error 1

https://github.com/passagemath/passagemath/actions/runs/16282518442/job/45974775509#step:11:3870

@mkoeppe
Copy link
Author

mkoeppe commented Jul 15, 2025

(There is already a -no-undefined in the root Makefile.am, but that appears to be purely decorative.)

@mkoeppe
Copy link
Author

mkoeppe commented Jul 15, 2025

I can provide a CI for testing on mingw if there's interest.

@mkoeppe mkoeppe mentioned this pull request Jul 15, 2025
Open
10 tasks
@mkoeppe
Copy link
Author

mkoeppe commented Dec 5, 2025

ping

@mkoeppe mkoeppe mentioned this pull request Jan 2, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mkoeppe