Skip to content

Template of the output file name says that the tag is not defined - dead link - tags usage improvement #2428

@slrslr

Description

@slrslr

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Operating System

Linux

Steps to reproduce

In LC 3.64.0 (Linux AppImage) when export dialog appears, I can edit output file name template.

I had:
${FILENAME}-cut-merged-${EPOCH_MS}${EXT}

but I was surprised that LC did not automatically use segment/s label in the output file names,

While modifying output file name template, I have not seen any tags other than already used ones, so I have clicked question-mark icon and was taken to a dead link page:
https://github.com/mifi/lossless-cut/blob/master/import-export.md#customising-exported-file-names
maybe it should be modified to link right to:
https://github.com/mifi/lossless-cut/blob/master/docs.md#custom-exported-file-names

this page shows tags like: ${SEG_LABEL}

So I have used it in the template: ${FILENAME}-cut-merged-${SEG_LABEL}${EXT}

Yet the result is: ReferenceError: SEG_LABEL is not defined

This is weird error for 2 reasons:

  1. it is in english despite i am using non-english translation which is 100% translated at https://hosted.weblate.org/projects/losslesscut/losslesscut/
  2. "not defined" suggests that LC is not aware about it, despite webpage shown it as available tag. In this case I am merging two segments each labelled differently. On the first look, I have missed column "Avail. when merging?" on the webpage. So maybe that is the reason of "is not defined" error, though more user friendly error would be "is not available when merging multiple segments".

Also maybe LC should allow saving the template anyway and just notify it will be omitted in this export case. Actually I think that LC should not omit it, but include all segments labels in the filename comma separated, if the total filename length would be within acceptable length (160-200 characters?).

Summary of possible improvements to consider:

  • Updating link

  • Translate error messages from JavaScript (more user friendly error/warning), or throw custom i18n errors before those occur

  • Label tag be used by default and applied only when used and if all tags would cause too long filename, maybe just trim it, placing "..." after last tag in filename.

Actual behavior

Share log from developer tools

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions