Conversation
|
Beware! As stated in #351 and the documentation, the Do you know what’s the time unit provided by |
|
Well, this change won't "break" anything, because old code won't be trying to get that non-existent value, I think? If you mean that it would be possible to write new code that used this time and that worked in some cases and not others, perhaps so. This could be documented? Having a way to measure the time between MIDI events would be really useful. Having to compute that time in Python at the end after the event has come through a cascade of Python code just savages both the accuracy and the precision of the result. |
|
Actually, calling it
I'm going to make this change and rebase it. |
|
I too would love to have that information available. Thanks for understanding ! |
|
The build failure seems to be some configuration issue where it can't even find Python 2.7 and nothing to do with my delta. |
|
Hey, I have fallen into so many such traps before. :-D Honestly, I'd rather the name were a bit too long, but clear to "the next guy". Typing doesn't slow me down, mistakes do! Is there some way to discover the units of the time field at this point in the code, now you mention it? |
|
Not that I’m aware but I’m quite new here. |
|
Upon looking at the rtmidi code, what they provide is a time delta since the previously received message (aka relative time) and its unit is in milliseconds. |
|
Ah, I'm so sorry. Yes, I did know that. In fact, in my hacked-up client
code, I keep an accumulator of the current time.
…On Mon, Apr 11, 2022 at 9:26 AM Raphaël Doursenaud ***@***.***> wrote:
Upon looking at the *rtmidi* code, what they provide is a time *delta*
since the previously received message (aka relative time) and its unit is
in *milliseconds*.
—
Reply to this email directly, view it on GitHub
<#193 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB53MQGA63WA3LMXJQANJDVEPHY7ANCNFSM4G24GKUA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
/t
PGP Key: ***@***.***
*https://tom.ritchford.com <https://tom.ritchford.com>*
*https://tom.swirly.com <https://tom.swirly.com>*
|
rdoursenaud
left a comment
There was a problem hiding this comment.
Please add a bit of documentation about the new rtdata_time attribute and maybe rename it to something more generic like backend_delta_time so we can make use of it in other backends.
Thanks!
|
I too would like to be able to retrieve midi timestamps. |
|
@stephen322 No ETA yet but I intend to ship this feature with MIDO 2.0. Got distracted implementing a native port backend for Windows in the meantime though. Once I finish debugging it, I'll resume work on version 2. |
|
MIDI 2.0!!! wowowow!
Unfortunately, I am itinerant right now, which means I have nothing that
accepts MIDI inputs, nor a MIDI interface, to help you!
But I'm very willing to do code reviews or anything else you need, I have
lots of spare time at the present.
Thanks again for years of sustained work on this excellent module.
…On Fri, Apr 5, 2024 at 4:53 AM Raphaël Doursenaud ***@***.***> wrote:
@stephen322 <https://github.com/stephen322> No ETA yet but I intend to
ship this feature with MIDO 2.0
<#540>. Got distracted
implementing a native port backend for Windows in the meantime though. Once
I finish debugging it, I'll resume work on version 2.
If you *really* need this now, I'd be happy to accept a PR against 1.x
with the issues highlighted in this thread fixed ;)
—
Reply to this email directly, view it on GitHub
<#193 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB53MUZUIZOV2KSLKTB2DDY3YG3PAVCNFSM4G24GKUKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBTHA3TCNRZGI4A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
/t
PGP Key: ***@***.***
*https://tom.ritchford.com <https://tom.ritchford.com>*
*https://tom.swirly.com <https://tom.swirly.com>*
|
The time is just sitting there, waiting to be used. :-)
I understand that it's basically "time relative to the previous MIDI event" but that's actually really useful for me, at least, and it costs you nothing to do.