Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

Spring Boot 3.x integration. Fixes #485#504

Merged
rdebusscher merged 6 commits intomicrostream-one:masterfrom
rdebusscher:spring-boot3
Jan 19, 2023
Merged

Spring Boot 3.x integration. Fixes #485#504
rdebusscher merged 6 commits intomicrostream-one:masterfrom
rdebusscher:spring-boot3

Conversation

@rdebusscher
Copy link
Copy Markdown

Support for Spring Boot 3 which requires now the usage of AutoConfiguration and no longer spring.factories file.

Creation of a common artifact in a way

  • It is compatible with current version 7.1 (no changes needed in user code, nor pom.xml)
    -No code changes required when moving from Spring Boot 2 to 3 version (just pom.xml to update)

@zdenek-jonas
Copy link
Copy Markdown
Contributor

zdenek-jonas commented Jan 10, 2023

I would prefer to see the common as a library only, with no dependency on mIcrostream.
Just the Configuration java classes.
For the safety of future use, it's better if there are as few dependencies as possible.
I would leave the dependency on Microstream and other spring components to the implementation.

@rdebusscher
Copy link
Copy Markdown
Author

@zdenek-jonas As discussed, the PR without spring-boot-common module.

@zdenek-jonas
Copy link
Copy Markdown
Contributor

zdenek-jonas commented Jan 19, 2023

Spring must add this dependency to generate the metadata file from custom configuration fields. This file is essential for IDE (such as IntelliJ) to enable context suggestions for developers. To add

        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-configuration-processor</artifactId>
            <version>${org.springframework.boot.version}</version>
            <scope>provided</scope>
            <optional>true</optional>
        </dependency>

And also please add enforce plugin to check if this file exists (like spring boot 2)

Some more information about:
https://docs.spring.io/spring-boot/docs/current/reference/html/configuration-metadata.html#appendix.configuration-metadata.annotation-processor

@rdebusscher rdebusscher merged commit c49966e into microstream-one:master Jan 19, 2023
@rdebusscher rdebusscher deleted the spring-boot3 branch January 19, 2023 15:02
@rdebusscher rdebusscher added this to the 08.00.00 milestone Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants