This repository was archived by the owner on Jan 9, 2025. It is now read-only.
fix to make the build compliant with maven 4#471
Merged
Conversation
|
@rfichtner I thought that config for maven-dependency-plugin came from the Helidon code generation (and thus recommended by Oracle Helidon team). I'll have a look to see if your PR breaks something and what the current code generation does different (the generated pom is now different) |
rdebusscher
approved these changes
Nov 24, 2022
rdebusscher
left a comment
rdebusscher
left a comment
There was a problem hiding this comment.
Helidon Example still works with the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @rdebusscher can you take a look at this.