This repository was archived by the owner on Jan 9, 2025. It is now read-only.
Quarkus integration#422
Merged
rdebusscher merged 14 commits intomicrostream-one:masterfrom Nov 18, 2022
rdebusscher:quarkus-integration
Merged
Quarkus integration#422rdebusscher merged 14 commits intomicrostream-one:masterfrom rdebusscher:quarkus-integration
rdebusscher merged 14 commits intomicrostream-one:masterfrom
rdebusscher:quarkus-integration
Conversation
added 5 commits
August 31, 2022 16:41
zdenek-jonas
reviewed
Sep 2, 2022
zdenek-jonas
reviewed
Sep 2, 2022
zdenek-jonas
reviewed
Sep 2, 2022
zdenek-jonas
reviewed
Sep 2, 2022
...src/main/java/one/microstream/integrations/quarkus/types/impl/BeanCreatorParameterNames.java
Show resolved
Hide resolved
zdenek-jonas
reviewed
Sep 2, 2022
.../runtime/src/main/java/one/microstream/integrations/quarkus/types/impl/StorageClassInfo.java
Show resolved
Hide resolved
zdenek-jonas
reviewed
Sep 2, 2022
integrations/quarkus/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
* setup javac as default * add check if the spring-configuration-metadata.json exists in target. (cherry picked from commit ac6eadd)
Contributor
|
Please do sync merge with master first... now we have a lot of changes that are already in master... |
hg-ms
reviewed
Oct 27, 2022
Contributor
hg-ms
left a comment
hg-ms
left a comment
There was a problem hiding this comment.
I saw several unnecessary empty line in several files, maybe you can remove some of them
...a/one/microstream/integrations/quarkus/types/config/EmbeddedStorageFoundationCustomizer.java
Outdated
Show resolved
Hide resolved
...main/java/one/microstream/integrations/quarkus/deployment/MicrostreamExtensionProcessor.java
Outdated
Show resolved
Hide resolved
...main/java/one/microstream/integrations/quarkus/deployment/MicrostreamExtensionProcessor.java
Outdated
Show resolved
Hide resolved
...ment/src/main/java/one/microstream/integrations/quarkus/deployment/StorageBeanBuildItem.java
Outdated
Show resolved
Hide resolved
...untime/src/main/java/one/microstream/integrations/quarkus/types/impl/StorageBeanCreator.java
Outdated
Show resolved
Hide resolved
.../runtime/src/main/java/one/microstream/integrations/quarkus/types/impl/StorageClassInfo.java
Outdated
Show resolved
Hide resolved
hg-ms
approved these changes
Nov 3, 2022
fh-ms
reviewed
Nov 14, 2022
| .done(); | ||
|
|
||
| } | ||
| else |
...us/deployment/src/test/java/one/microstream/integrations/quarkus/deployment/CleanupUtil.java
Outdated
Show resolved
Hide resolved
Contributor
|
Another thought, shouldn't the |
Author
Maybe/probably. But I'm just following the same naming which was introduced at first with the CDI integration And later on also used in Spring Boot integration. If it needs to be different, we should also use the new name for the 2 other integrations. |
fh-ms
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension for Quarkus.
Support for StorageManager configuration through config parameters
Root bean creation (@Storage)
Customizer of Foundation and initial data.
Examples, see https://github.com/rdebusscher/microstream-quarkus-patterns