This repository was archived by the owner on Jan 9, 2025. It is now read-only.
Conversation
Implemented a callback to the application-side ObjectRegistry for the GC sweep to check before deleting an entity. Also, storers are kept alive until the next sweep is completed to guarantee at least one strong reference to everything they reference locally / stored. Tested to work as intended and not cause regression problems.
Changed ObjectRegistry to use a dual-locking strategy with an additional internal mutex that can never cause deadlocks and the storage thread only requiring that instead of the process-spanning "big" / "outer" lock.
zdenek-jonas
reviewed
Aug 9, 2022
hg-ms
reviewed
Aug 9, 2022
...ce/persistence/src/main/java/one/microstream/persistence/internal/DefaultObjectRegistry.java
Outdated
Show resolved
Hide resolved
hg-ms
reviewed
Aug 9, 2022
...ce/persistence/src/main/java/one/microstream/persistence/internal/DefaultObjectRegistry.java
Show resolved
Hide resolved
hg-ms
reviewed
Aug 9, 2022
...rsistence/src/main/java/one/microstream/persistence/types/PersistenceLiveStorerRegistry.java
Outdated
Show resolved
Hide resolved
hg-ms
reviewed
Aug 9, 2022
...rsistence/src/main/java/one/microstream/persistence/types/PersistenceLiveStorerRegistry.java
Outdated
Show resolved
Hide resolved
zdenek-jonas
approved these changes
Aug 9, 2022
hg-ms
reviewed
Aug 9, 2022
...rc/main/java/one/microstream/storage/embedded/types/EmbeddedStorageConnectionFoundation.java
Outdated
Show resolved
Hide resolved
hg-ms
reviewed
Aug 9, 2022
...embedded/src/main/java/one/microstream/storage/embedded/types/EmbeddedStorageFoundation.java
Outdated
Show resolved
Hide resolved
hg-ms
reviewed
Aug 9, 2022
.../main/java/one/microstream/storage/embedded/types/EmbeddedStorageObjectRegistryCallback.java
Show resolved
Hide resolved
hg-ms
approved these changes
Aug 9, 2022
fh-ms
added a commit
that referenced
this pull request
Aug 9, 2022
Add live object check to GC. Ensures retaining of objects in storage when still live in VM. Additional regression concurrency fix. Finally fixes all remaining GC issues, brings it out of the experimental stage and activates it by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add live object check to GC. Ensures retaining of objects in storage when still live in VM. Additional regression concurrency fix.
Finally fixes all remaining GC issues, brings it out of the experimental stage and activates it by default.