This repository was archived by the owner on Jan 9, 2025. It is now read-only.
Merged
Conversation
fh-ms
suggested changes
Jun 22, 2022
| import one.microstream.persistence.exceptions.PersistenceException; | ||
|
|
||
| @SuppressWarnings("serial") | ||
| public class PersistenceExceptionTypeImportTypeNotFound extends PersistenceException |
Contributor
There was a problem hiding this comment.
Should be called BineraPersistenceExceptionTypeImportTypeNotFound, extends from BinaryPersistenceException and be in package one.microstream.persistence.binary.exceptions.
|
|
||
| import java.util.Collection; | ||
|
|
||
| public class SerializerTypeInfo |
Contributor
There was a problem hiding this comment.
Better work with our collections than java.util.Collection and arrays. Array member assignments are mutable.
Best to hand in a XGettingList<String> and assign it to a XGettingList<String> field by calling the immure method to make it immutable.
fh-ms
approved these changes
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.