Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

Stop LazyrefenceManager automatically#343

Merged
rdebusscher merged 2 commits intomicrostream-one:masterfrom
rdebusscher:Stop_lazyRefManager
Apr 21, 2022
Merged

Stop LazyrefenceManager automatically#343
rdebusscher merged 2 commits intomicrostream-one:masterfrom
rdebusscher:Stop_lazyRefManager

Conversation

@hg-ms
Copy link
Copy Markdown
Contributor

@hg-ms hg-ms commented Apr 20, 2022

@hg-ms hg-ms requested a review from fh-ms April 20, 2022 11:24
this.controllerCount--;

// adding logic ensures there can be at the most one entry, so one match suffices to end the loop.
stopIfNoControllers();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this. qualifier to instance method calls.

{
if (this.controllerCount == 0)
{
stop();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this. qualifier to instance method calls.

@fh-ms fh-ms added this to the 07.00.00 milestone Apr 20, 2022
@fh-ms fh-ms added the enhancement New feature or request label Apr 20, 2022
@rdebusscher rdebusscher requested a review from fh-ms April 21, 2022 08:53
@rdebusscher rdebusscher merged commit f34a51e into microstream-one:master Apr 21, 2022
@fh-ms
Copy link
Copy Markdown
Contributor

fh-ms commented Apr 21, 2022

The manual stop of the lazy reference manager in one.microstream.integrations.cdi.types.StorageManagerProducer#dispose probably can be removed based on this enhancement.

@rdebusscher rdebusscher deleted the Stop_lazyRefManager branch April 26, 2022 15:13
fh-ms pushed a commit that referenced this pull request Oct 11, 2022
Stop LazyrefenceManager automatically
@fh-ms fh-ms mentioned this pull request Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants