Always use the proxyPort when provided and add missing docbloc#98
Merged
MIchaelMainer merged 2 commits intomicrosoftgraph:devfrom Sep 18, 2018
Merged
Always use the proxyPort when provided and add missing docbloc#98MIchaelMainer merged 2 commits intomicrosoftgraph:devfrom
MIchaelMainer merged 2 commits intomicrosoftgraph:devfrom
Conversation
The proxy would not be used when calling upload() or download() on GraphRequest.
Zombaya
changed the title
MIchaelMainer
approved these changes
Sep 13, 2018
Collaborator
MIchaelMainer
left a comment
MIchaelMainer
left a comment
There was a problem hiding this comment.
Thank you for providing this fix. We'll add this to the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provided proxyPort would not be used when calling the method
upload()anddownload()of the classGraphRequest. This resulted in missing requests when trying to debug uploads and downloads to onedrive.Also fixed a missing docbloc entry in GraphColllectionRequest.