Put added in custom request.#206
Conversation
|
|
||
| /** | ||
| * Test PUT with a custom request for both serialized and JSON content | ||
| */ |
There was a problem hiding this comment.
you added two put methods, but only one test, can you please add one more test covering other function?
There was a problem hiding this comment.
Updated tests to cover both Put functions added.
There was a problem hiding this comment.
hey, ideally you should create two separate tests for two methods.
|
I'd like to discuss further why we actually have a customRequest class. When we move to the Apache HttpClient library that has a native request object, will this be needed anymore? The overall idea is that we can convert the output of a Request Builder to a native request object , so that users can do what ever manipulation you want. Adding PUT to the customRequest class feels like we are slowly re-inventing a native HTTP library. |
|
As discussed, we are going ahead and merging this pull request. |
4 participants
Fixes #185
Changes proposed in this pull request