Skip to content

Send attachment with mail#202

Merged
baywet merged 10 commits intodevfrom
attachment-bug-fix
Sep 9, 2020
Merged

Send attachment with mail#202
baywet merged 10 commits intodevfrom
attachment-bug-fix

Conversation

@NakulSabharwal
Copy link
Copy Markdown
Contributor

@NakulSabharwal NakulSabharwal commented Jan 6, 2019

Fixes #192
Fixes #90

Changes proposed in this pull request

  • Serializer for attachments.
  • Tests for sending attachment with email.
  • Expose attachment attribute

@baywet baywet self-assigned this Aug 17, 2020
@github-actions

This comment has been minimized.

@baywet baywet added this to the 2.0.1 milestone Sep 2, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2020

Conflicts have been resolved. A maintainer will take a look shortly.

baywet
baywet previously approved these changes Sep 8, 2020
Copy link
Copy Markdown
Collaborator

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed online with Vincent

@baywet baywet merged commit dd7778c into dev Sep 9, 2020
@baywet baywet deleted the attachment-bug-fix branch September 9, 2020 15:44
@baywet baywet mentioned this pull request Sep 18, 2020
@Przemek-12
Copy link
Copy Markdown

Przemek-12 commented Oct 2, 2020

Hi, I can't send mail message with attachment. I use exact same code as in unit tests. I get NoSuchMethodException at CollectionPageSerializer class, line 84.
java.lang.NoSuchMethodError: 'com.google.gson.JsonElement com.google.gson.JsonParser.parseString(java.lang.String)'.
In JsonParser class, there's no parseString method. There's only parse(String json).

@baywet
Copy link
Copy Markdown
Member

baywet commented Oct 2, 2020

hi @Przemek-12
Can you open a separate issue please so it's easier for us to have a focused discussion?
Thanks!

@Przemek-12
Copy link
Copy Markdown

hi, just opened it: #515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants