Skip to content

fix: include mgt-mock-provider as dependency to mgt#2336

Merged
gavinbarron merged 1 commit intonext/fluentuifrom
bug/include-mock-provider-in-mgt
May 22, 2023
Merged

fix: include mgt-mock-provider as dependency to mgt#2336
gavinbarron merged 1 commit intonext/fluentuifrom
bug/include-mock-provider-in-mgt

Conversation

@gavinbarron
Copy link
Copy Markdown
Member

Closes #2333

PR Type

  • Bugfix

Description of the changes

Adds @microsoft/mgt-mock-provider as a dependency in package.json of @microsoft/mgt

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

@gavinbarron gavinbarron requested a review from a team as a code owner May 22, 2023 09:02
@ghost
Copy link
Copy Markdown

ghost commented May 22, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron requested a review from musale May 22, 2023 09:02
@gavinbarron gavinbarron linked an issue May 22, 2023 that may be closed by this pull request
@gavinbarron gavinbarron enabled auto-merge (squash) May 22, 2023 09:04
@gavinbarron gavinbarron merged commit b166aaf into next/fluentui May 22, 2023
@gavinbarron gavinbarron deleted the bug/include-mock-provider-in-mgt branch May 22, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG] mgt-mock-provider not bundled in @microsoft-mgt

2 participants