Fix build errors for same method and property name#177
Merged
MIchaelMainer merged 4 commits intomicrosoftgraph:devfrom Feb 1, 2019
Merged
Fix build errors for same method and property name#177MIchaelMainer merged 4 commits intomicrosoftgraph:devfrom
MIchaelMainer merged 4 commits intomicrosoftgraph:devfrom
Conversation
Now allows GetSanitizedPropertyName to accept an additional parameter, suffix, so that an additional string may be concatenated onto the end of the Property. Updated method logic to look for and concatenate suffix when specified.
Updates IEntityRequestBuilder.Base.template.tt so that it does not create properties with the same name as the methods within the class (specifically request), by concatenating a "_" to the end of the property name.
Updates EntityRequestBuilder.Base.template.tt so that it does not create properties with the same name as the methods within the class (specifically request), by concatenating a "_" to the end of the property name.
PxlBuzzard
previously approved these changes
Jan 31, 2019
Deletes invalid reference paths to avoid namespace errors
PxlBuzzard
approved these changes
Feb 1, 2019
MIchaelMainer
approved these changes
Feb 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes build errors brought about due to template file instantiating property to have same name as methods within the same class. The commits within this PR perform a specific check to ensure this does not happen, allowing successful build.