Merged
Conversation
src/GraphODataTemplateWriter/CodeHelpers/ObjC/TypeHelperObjC.cs
Outdated
Show resolved
Hide resolved
MIchaelMainer
requested changes
Jan 22, 2019
Collaborator
MIchaelMainer
left a comment
MIchaelMainer
left a comment
There was a problem hiding this comment.
Can you address my comment about supporting ODate Duration? Also, can you attach a couple examples of generated code files to the PR? It is helpful when reviewing these template changes.
MIchaelMainer
approved these changes
Jan 30, 2019
darrelmiller
approved these changes
Jan 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request address the following things:
Some examples showing difference in some of the files due to these changes :
objc_gen.zip