Java template fix to reduce memory footprint - continued#136
Merged
deepak2016 merged 2 commits intodevfrom Jun 22, 2018
Merged
Conversation
…template generates ~200 files and helps improve memory footprint for java sdk.
… template generates ~400 files and helps improve memory footprint for java sdk
MIchaelMainer
approved these changes
Jun 21, 2018
Collaborator
MIchaelMainer
left a comment
MIchaelMainer
left a comment
There was a problem hiding this comment.
This change looks good.
I propose a new requirement for reviewing template changes. We should attach an example of the generated files before and after a proposed change. This will provide better context for reviewing pull requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together these templates impact ~800 files and these files will start getting optimized import statements with this fix.
Testing:
After generating files using these templates, java sdk has started building with 4GB RAM.