Skip to content

docs: clarify agent-framework hosted-agent toolbox sample prerequisites and setup - #1082

Merged
Ankit Sinha (ankitbko) merged 12 commits into
mainfrom
docs/toolbox-setup-instructions
Oct 22, 2026
Merged

Ankit Sinha (ankitbko) merged 12 commits into
mainfrom
docs/toolbox-setup-instructions

Conversation

@dargilco

@dargilco Darren Cohen (dargilco) commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Clarifies the Foundry Toolbox sample setup, including required credentials, Azure Language resource configuration, and managed identity permissions. Updates the deployment and invocation steps, corrects the azd commands, and adds troubleshooting guidance for common setup failures.

@dargilco
Darren Cohen (dargilco) requested a review from a team as a code owner October 20, 2026 01:10
Copilot AI balanced review requested due to automatic review settings October 20, 2026 01:10
@dargilco
Darren Cohen (dargilco) marked this pull request as draft October 20, 2026 01:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation aligns with the sample manifest and authorization guide, with no unresolved findings.

No open issues 🎉

What changed in this PR

Clarifies prerequisites and setup for the Python Foundry Toolbox hosted-agent sample.

Changes:

  • Explains GitHub token and Azure Language endpoint preparation.
  • Separates provisioning, managed-identity authorization, and deployment.
  • Clarifies local execution requirements and troubleshooting for missing azd projects.
File Description
samples/​python/​hosted-agents/​agent-framework/​responses/​04-foundry-toolbox/​README.md Clarifies prerequisites, deployment order, and troubleshooting.

Review effort: Balanced

@dargilco
Darren Cohen (dargilco) marked this pull request as ready for review October 20, 2026 21:46
Copilot AI balanced review requested due to automatic review settings October 20, 2026 21:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only changes clarify the supported setup workflow, with no unresolved findings.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 21, 2026 16:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation matches the sample configuration and setup workflow, with no blocking issues identified.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 21, 2026 16:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only changes align with the sample configuration and supporting guidance, with no unresolved issues identified.

No open issues 🎉

Review effort: Balanced

@dargilco Darren Cohen (dargilco) changed the title docs: clarify toolbox sample prerequisites and setup docs: clarify agent-framework hosted-agent toolbox sample prerequisites and setup Oct 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation changes align with the sample configuration and authorization guidance, with no unresolved blocking issues.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 21, 2026 21:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation aligns with the sample configuration and initialization flow, with no unresolved blocking issues identified.

No open issues 🎉

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only changes have no identified blockers, with only a minor wording inconsistency remaining.

1 open issue

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 22, 2026 18:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation changes clarify the supported setup flow, and no unresolved blocking issues were identified.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 22, 2026 20:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation changes are focused and consistent with the sample configuration, with no unresolved issues identified.

No open issues 🎉

Review effort: Balanced

@ankitbko
Ankit Sinha (ankitbko) merged commit 86a5adf into main Oct 22, 2026
32 checks passed
@ankitbko
Ankit Sinha (ankitbko) deleted the docs/toolbox-setup-instructions branch October 22, 2026 21:09

This branch was previously deployed

1 inactive deployment
L4-validation — c6627b4e Deployed Oct 22, 2026 by dargilco via trusted #633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants