Skip to content

New version: LizardByte.Sunshine version 0.14.1 #69256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
4 commits merged into from
Aug 11, 2022
Merged

New version: LizardByte.Sunshine version 0.14.1 #69256

4 commits merged into from
Aug 11, 2022

Conversation

@sitiom
Copy link
Contributor

@sitiom sitiom commented Aug 10, 2022 •
edited by ghost
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.1 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

wingetbot commented Aug 10, 2022

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

wingetbot commented Aug 10, 2022

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

wingetbot commented Aug 10, 2022

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@sitiom sitiom mentioned this pull request Aug 10, 2022
Closed
7 tasks
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Aug 10, 2022
@ghost
Copy link

ghost commented Aug 10, 2022

Hello @sitiom,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Aug 10, 2022
ReenigneArcher
ReenigneArcher reviewed Aug 10, 2022
View reviewed changes
@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Aug 10, 2022
@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 10, 2022
@wingetbot
Copy link
Collaborator

wingetbot commented Aug 10, 2022

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Aug 10, 2022
@ghost
Copy link

ghost commented Aug 10, 2022

Hello @sitiom,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Aug 10, 2022
@ghost ghost removed the Manifest-Validation-Error Manifest validation failed label Aug 10, 2022
@wingetbot
Copy link
Collaborator

wingetbot commented Aug 10, 2022

/AzurePipelines run

@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Aug 10, 2022
@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 10, 2022
@ghost
Copy link

ghost commented Aug 10, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 10, 2022

sitiom,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 11, 2022
@ghost
Copy link

ghost commented Aug 11, 2022

Hello sitiom,
Validation has completed.

Template: msftbot/validationCompleted

@ghost ghost merged commit 86abf90 into microsoft:master Aug 11, 2022
@sitiom sitiom deleted the LizardByte.Sunshine-0.14.1-132EF028B197A5 branch August 11, 2022 01:20
@wingetbot
Copy link
Collaborator

wingetbot commented Aug 11, 2022

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher left review comments

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sitiom @wingetbot @ItzLevvie @ReenigneArcher